Development / contributions | General Support | Forum

Avatar

Please consider registering
Guest

Search

— Forum Scope —




— Match —





— Forum Options —





Minimum search word length is 3 characters - maximum search word length is 84 characters

Register Lost password?
sp_Feed sp_TopicIcon
Development / contributions
Avatar
Dan
Member
Members
Forum Posts: 3
Member Since:
January 1, 2019
sp_UserOfflineSmall Offline
1
January 1, 2019 - 3:37 pm
sp_Permalink sp_Print

Hi,

I want to launch a site based on plikli and I'd like to submit some improvements.
What is the preferred channel for dev discussions?

I've only opened some pull requests on Github:
https://github.com/Plikli-CMS/Plikli-CMS/pull/4
https://github.com/Plikli-CMS/Plikli-CMS/pull/5
https://github.com/Plikli-CMS/Plikli-CMS/pull/6

Thanks,
Dan

Avatar
redwine
Admin
Forum Posts: 341
Member Since:
February 21, 2018
sp_UserOfflineSmall Offline
2
January 2, 2019 - 2:55 pm
sp_Permalink sp_Print

Hello Dan and welcome to Plikli Community!

Thank you for your input. I checked your pull requests and these are my notes:

About the Fix CREATE TABLE sql, some tables don't have a default value for `timestamp`
They are without a default value for a purpose. Look at the code for every instance.

I noticed that you also have changed
`link_url` varchar($urllength) to varchar(255)

Again, look at the code when installing/upgrading and you will see that the varchar value depends on the MySQL version that the the user installing the CMS is using.

- I will go through the Support custom mysql server port and implement it.

- The PHP7: Replace deprecated each() function usage
Currently I am working on many things at the same time, namely:

1- replacing all deprecated functions to be fully compliant with php 7 and migrating from MySQL to PDO with prepared statements.
2- Cleaning the code from all the legacy and redundant or obsolete code that is still carried on since the earliest Pligg versions.

You can still continue working on your github instance and submit pull requests for to revise.

Thank you for your input and efforts!

Avatar
Dan
Member
Members
Forum Posts: 3
Member Since:
January 1, 2019
sp_UserOfflineSmall Offline
3
January 2, 2019 - 10:35 pm
sp_Permalink sp_Print

Hi Redmine, thanks for your prompt feedback!

> About the Fix CREATE TABLE sql, some tables don't have a default value for `timestamp`
> They are without a default value for a purpose. Look at the code for every instance.
I see what you mean. They are also set up as `NOT NULL` and the SQL query fails on my server (version 5.7.22). That's why I had to do the changes. I'll look into it in detail and see what I can improve.

>You can still continue working on your github instance and submit pull requests for to revise.

Yes, I'm working on my own fork and thought it's best that I share my changes with the other users.

I'm looking forward to the PHP7 and PDO updates, that would be very helpful!
If I can help with anything, please let me know.

Happy New Year!

Avatar
redwine
Admin
Forum Posts: 341
Member Since:
February 21, 2018
sp_UserOfflineSmall Offline
4
January 3, 2019 - 12:22 am
sp_Permalink sp_Print

"Yes, I'm working on my own fork and thought it's best that I share my changes with the other users."

As a courtesy and professionally, you should not share anything with the users. All you will be doing is confusing them and they end up applying some of your implementation, while I did not integrated them in Plikli.

If you want to be involved, you have forked Plikli and you can continue working on yours and submit pull requests for me to revise and commit, if they are accepted.

I had a Pligg fork and submitted tons of pull requests that were all committed, and never shared them directly with Pligg users, even though I was the forum support. I always went through Pligg!!!

I expect the same from you!

Avatar
Dan
Member
Members
Forum Posts: 3
Member Since:
January 1, 2019
sp_UserOfflineSmall Offline
5
January 3, 2019 - 2:18 am
sp_Permalink sp_Print

Oh, I meant sharing them through the official repo. I will of course submit pull requests. Sorry for the confusion

Avatar
redwine
Admin
Forum Posts: 341
Member Since:
February 21, 2018
sp_UserOfflineSmall Offline
6
January 3, 2019 - 3:35 am
sp_Permalink sp_Print

Thank you very much and looking forward to keep hearing from you!

Forum Timezone: Asia/Beirut

Most Users Ever Online: 28

Currently Online:
3 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

john: 47

Nishant kumar: 33

Mosage: 25

Punk: 23

Martin Gold: 22

Felipe: 21

StaticMove: 13

Hiro: 13

yami: 13

Cesar: 12

Newest Members:

Kajal Raj

Nik

Mannes

sandeep

Vityola

alex

larkpeyton

Mohi Uddin

Sandeep Verma

sansui

Forum Stats:

Groups: 1

Forums: 8

Topics: 118

Posts: 690

 

Member Stats:

Guest Posters: 0

Members: 144

Moderators: 0

Admins: 1

Administrators: redwine